Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22151 to 7.10: Fix zeek connection pipeline #22160

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Oct 26, 2020

Cherry-pick of PR #22151 to 7.10 branch. Original message:

What does this PR do?

  • changes connection state for rejected from 'REG' to 'REJ'

https://docs.zeek.org/en/current/scripts/base/protocols/conn/main.zeek.html

Why is it important?

Rejected connection states weren't matching.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=zeek TESTING_FILEBEAT_FILESETS=connection mage -v pythonIntegTest

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 26, 2020
- connection state for rejected is 'REJ'

Closes elastic#22149

(cherry picked from commit 5469c46)
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 26, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22160 updated]

  • Start Time: 2020-10-27T02:37:33.550+0000

  • Duration: 70 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@leehinman leehinman merged commit d99bbd8 into elastic:7.10 Oct 27, 2020
@zube zube bot removed the [zube]: Done label Jan 26, 2021
@leehinman leehinman deleted the backport_22151_7.10 branch May 14, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants